Skip to content

fix: make sure default contact exists by default#53919

Merged
st3iny merged 1 commit intomasterfrom
fix/default-contact
Sep 17, 2025
Merged

fix: make sure default contact exists by default#53919
st3iny merged 1 commit intomasterfrom
fix/default-contact

Conversation

@hamza221
Copy link
Contributor

@hamza221 hamza221 commented Jul 11, 2025 •
edited by st3iny
Loading

Summary

Create default contact file when the first example contact is to be created.

Checklist

@hamza221 hamza221 requested a review from st3iny July 11, 2025 15:08
@hamza221 hamza221 self-assigned this Jul 11, 2025
@hamza221 hamza221 requested a review from a team as a code owner July 11, 2025 15:08
@hamza221 hamza221 requested review from Altahrim, ArtificialOwl and skjnldsv and removed request for a team July 11, 2025 15:08
@hamza221 hamza221 force-pushed the fix/default-contact branch from 6096ea1 to 3cfa5ed Compare July 14, 2025 12:45
st3iny
st3iny approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix the problem.

@st3iny st3iny force-pushed the fix/default-contact branch from 3cfa5ed to 235f311 Compare July 22, 2025 09:26
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 22, 2025
@hamza221 hamza221 enabled auto-merge July 22, 2025 11:04
@hamza221 hamza221 disabled auto-merge July 22, 2025 12:14
@skjnldsv skjnldsv force-pushed the fix/default-contact branch from 235f311 to ab4330a Compare August 1, 2025 07:35
@skjnldsv
Copy link
Member

skjnldsv commented Aug 1, 2025

Related failures

--- Failed scenarios:
    /home/runner/actions-runner/_work/server/server/build/integration/collaboration_features/autocomplete.feature:44
    /home/runner/actions-runner/_work/server/server/build/integration/collaboration_features/autocomplete.feature:65

@skjnldsv skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Aug 1, 2025
st3iny
st3iny reviewed Aug 12, 2025
View reviewed changes
@st3iny st3iny force-pushed the fix/default-contact branch from 81db07f to f075c06 Compare August 25, 2025 10:43
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 25, 2025
@st3iny

This comment was marked as resolved.

Sign in to view
@st3iny st3iny force-pushed the fix/default-contact branch from f075c06 to 3c02eb3 Compare August 25, 2025 11:17
@st3iny
Copy link
Member

st3iny commented Aug 25, 2025

@hamza221 I'm starting to believe that the integration test failure is somehow related.

@hamza221
Copy link
Contributor Author

hamza221 commented Sep 3, 2025

@hamza221 I'm starting to believe that the integration test failure is somehow related.

I'll try to get it in before tommorow's rc

@AndyScherzinger AndyScherzinger added this to the Nextcloud 33 milestone Sep 12, 2025
@hamza221 @st3iny
fix: make sure default contact exists by default
fa1dd4a 
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/default-contact branch from fa94bdc to fa1dd4a Compare September 17, 2025 08:57
@st3iny st3iny enabled auto-merge September 17, 2025 08:58
@st3iny
Copy link
Member

st3iny commented Sep 17, 2025

/backport to stable32

@st3iny st3iny merged commit 1b7cd00 into master Sep 17, 2025
212 of 217 checks passed
@st3iny st3iny deleted the fix/default-contact branch September 17, 2025 09:53
@backportbot
Copy link

backportbot bot commented Sep 17, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/53919/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fa1dd4a7

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/53919/stable32

Error: Failed to push branch backport/53919/stable32: remote: Invalid username or token. Password authentication is not supported for Git operations.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@st3iny
Copy link
Member

st3iny commented Sep 17, 2025

/backport to stable32

@backportbot backportbot bot mentioned this pull request Sep 17, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Oct 2, 2025
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st3iny st3iny st3iny approved these changes

@kesselb kesselb kesselb approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner automatically assigned from nextcloud/server-backend

Assignees

@hamza221 hamza221

Labels

4. to release Ready to be released and/or waiting for tests to finish bug regression

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

dav: default contact access polutes debug logs

6 participants

@hamza221 @skjnldsv @st3iny @kesselb @AndyScherzinger @ChristophWurst